Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Trigger event dropdown texts #788

Merged
merged 1 commit into from
Oct 13, 2023
Merged

fix: Trigger event dropdown texts #788

merged 1 commit into from
Oct 13, 2023

Conversation

cyaiox
Copy link
Contributor

@cyaiox cyaiox commented Oct 13, 2023

This PR fixes the trigger event dropdown text

@cyaiox cyaiox requested a review from cazala October 13, 2023 19:38
@cyaiox cyaiox enabled auto-merge (squash) October 13, 2023 19:39
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0de8f35
Status: ✅  Deploy successful!
Preview URL: https://ef35095d.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-triggers.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/triggers/dcl-sdk-7.3.22-6512395138.commit-ad6c4dd.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/triggers/dcl-sdk-commands-7.3.22-6512395138.commit-ad6c4dd.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/triggers/@dcl/inspector/dcl-inspector-7.3.22-6512395138.commit-ad6c4dd.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/triggers-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/triggers

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (86c99b1) 71.47% compared to head (0de8f35) 71.47%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #788   +/-   ##
=======================================
  Coverage   71.47%   71.47%           
=======================================
  Files         393      393           
  Lines       12957    12957           
  Branches     1749     1749           
=======================================
  Hits         9261     9261           
  Misses       3486     3486           
  Partials      210      210           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cyaiox cyaiox merged commit c604568 into main Oct 13, 2023
@cyaiox cyaiox deleted the fix/triggers branch October 13, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants