Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade @dcl/asset-packs #776

Merged
merged 2 commits into from
Oct 10, 2023
Merged

feat: upgrade @dcl/asset-packs #776

merged 2 commits into from
Oct 10, 2023

Conversation

cazala
Copy link
Member

@cazala cazala commented Oct 10, 2023

Upgrade @dcl/asset-packs

@cazala cazala enabled auto-merge (squash) October 10, 2023 14:21
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 10, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 013aeb3
Status: ✅  Deploy successful!
Preview URL: https://b57f97d8.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-upgrade-asset-packs-1-2.js-sdk-toolchain.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Oct 10, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/upgrade-asset-packs-1.2.2/dcl-sdk-7.3.20-6470904066.commit-dc3dbf6.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/upgrade-asset-packs-1.2.2/dcl-sdk-commands-7.3.20-6470904066.commit-dc3dbf6.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/upgrade-asset-packs-1.2.2/@dcl/inspector/dcl-inspector-7.3.20-6470904066.commit-dc3dbf6.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/upgrade-asset-packs-1.2.2-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/upgrade-asset-packs-1.2.2

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (9729b70) 71.51% compared to head (013aeb3) 71.51%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #776   +/-   ##
=======================================
  Coverage   71.51%   71.51%           
=======================================
  Files         390      390           
  Lines       12810    12810           
  Branches     1734     1734           
=======================================
  Hits         9161     9161           
  Misses       3441     3441           
  Partials      208      208           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cazala cazala merged commit 1f27e0b into main Oct 10, 2023
8 of 10 checks passed
@cazala cazala deleted the feat/upgrade-asset-packs-1.2.2 branch October 10, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants