Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Triggers css width #772

Merged
merged 1 commit into from
Oct 10, 2023
Merged

fix: Triggers css width #772

merged 1 commit into from
Oct 10, 2023

Conversation

cyaiox
Copy link
Contributor

@cyaiox cyaiox commented Oct 9, 2023

This PR fixes a CSS error with triggers that don't allow users to remove elements.

Closes: decentraland/sdk#957

@cyaiox cyaiox requested a review from cazala October 9, 2023 21:03
@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 9, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 97b3786
Status: ✅  Deploy successful!
Preview URL: https://4d783b45.js-sdk-toolchain.pages.dev
Branch Preview URL: https://fix-remove-triggers.js-sdk-toolchain.pages.dev

View logs

@cyaiox cyaiox force-pushed the fix/remove-triggers branch from a4dc7e8 to 9f974c6 Compare October 9, 2023 21:05
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/remove-triggers/dcl-sdk-7.3.20-6469846885.commit-dae961e.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/remove-triggers/dcl-sdk-commands-7.3.20-6469846885.commit-dae961e.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/fix/remove-triggers/@dcl/inspector/dcl-inspector-7.3.20-6469846885.commit-dae961e.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/fix/remove-triggers-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=fix/remove-triggers

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (ad4ad4b) 71.51% compared to head (9f974c6) 71.51%.
Report is 1 commits behind head on main.

❗ Current head 9f974c6 differs from pull request most recent head 97b3786. Consider uploading reports for the commit 97b3786 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #772   +/-   ##
=======================================
  Coverage   71.51%   71.51%           
=======================================
  Files         390      390           
  Lines       12810    12810           
  Branches     1734     1734           
=======================================
  Hits         9161     9161           
  Misses       3441     3441           
  Partials      208      208           
Files Coverage Δ
packages/@dcl/inspector/src/hooks/useArrayState.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cyaiox cyaiox force-pushed the fix/remove-triggers branch from 9f974c6 to 97b3786 Compare October 10, 2023 13:14
@cyaiox cyaiox enabled auto-merge (squash) October 10, 2023 13:15
@cyaiox cyaiox merged commit 9729b70 into main Oct 10, 2023
@cyaiox cyaiox deleted the fix/remove-triggers branch October 10, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't remove the last trigger condition
2 participants