Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: warning for missing keys on scene.json #769

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

nicoecheza
Copy link
Contributor

@nicoecheza nicoecheza commented Oct 5, 2023

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Oct 5, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: e8399f9
Status: ✅  Deploy successful!
Preview URL: https://784d9d3b.js-sdk-toolchain.pages.dev
Branch Preview URL: https://add-scene-display-warning.js-sdk-toolchain.pages.dev

View logs

@nicoecheza nicoecheza force-pushed the add/scene-display-warning branch from f0cf5f7 to 380fb69 Compare October 5, 2023 15:43
@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/add/scene-display-warning/dcl-sdk-7.3.19-6449988224.commit-1dd1b00.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/add/scene-display-warning/dcl-sdk-commands-7.3.19-6449988224.commit-1dd1b00.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/add/scene-display-warning/@dcl/inspector/dcl-inspector-7.3.19-6449988224.commit-1dd1b00.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/add/scene-display-warning-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=add/scene-display-warning

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (bf7aa87) 71.64% compared to head (0c3d22f) 71.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #769      +/-   ##
==========================================
+ Coverage   71.64%   71.66%   +0.02%     
==========================================
  Files         388      388              
  Lines       12770    12783      +13     
  Branches     1728     1732       +4     
==========================================
+ Hits         9149     9161      +12     
- Misses       3415     3416       +1     
  Partials      206      206              
Files Coverage Δ
...ges/@dcl/sdk-commands/src/commands/deploy/index.ts 22.36% <0.00%> (ø)
...s/@dcl/sdk-commands/src/logic/scene-validations.ts 97.43% <87.50%> (-2.57%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicoecheza nicoecheza force-pushed the add/scene-display-warning branch 3 times, most recently from 415c326 to eec47b0 Compare October 5, 2023 16:11
@nicoecheza nicoecheza marked this pull request as ready for review October 5, 2023 16:12
@nicoecheza nicoecheza force-pushed the add/scene-display-warning branch from eec47b0 to e8399f9 Compare October 5, 2023 16:18
@nicoecheza nicoecheza enabled auto-merge (squash) October 5, 2023 17:47
@nicoecheza nicoecheza force-pushed the add/scene-display-warning branch from e8399f9 to 0c3d22f Compare October 8, 2023 21:08
@nicoecheza nicoecheza merged commit bc3b2dc into main Oct 9, 2023
9 checks passed
@nicoecheza nicoecheza deleted the add/scene-display-warning branch October 9, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warn when scene missing name/description/thumbnail
2 participants