-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add tweens component #758
Conversation
Deploying with Cloudflare Pages
|
f008dd1
to
09828dc
Compare
// actions that may only be available under certain circumstances | ||
const conditionalActions: Partial<Record<string, () => boolean>> = useMemo( | ||
() => ({ | ||
[ActionType.PLAY_ANIMATION]: () => hasAnimations, | ||
[ActionType.SET_STATE]: () => hasStates | ||
[ActionType.SET_STATE]: () => hasStates, | ||
[ActionType.START_TWEEN]: () => hasTweens |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mm I think the start_tween
should not be conditional? You can always use the start tween on an entity. Also, the hasTweens
will always be false
for a brand new entity, so you would never be able to add tween actions to it. This seems to have slipped from the original version with the Tweens
component.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, updated!
Test this pull request
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #758 +/- ##
==========================================
- Coverage 72.53% 72.36% -0.18%
==========================================
Files 367 372 +5
Lines 12369 12399 +30
Branches 1693 1698 +5
==========================================
Hits 8972 8972
- Misses 3210 3235 +25
- Partials 187 192 +5
☔ View full report in Codecov by Sentry. |
This PR adds the tween action component, allowing the users to define: