Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: custom assets #1046

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

feat: custom assets #1046

wants to merge 26 commits into from
+1,455 −126

Conversation

cazala
Copy link
Member

@cazala cazala commented Dec 16, 2024

Add support for custom assets

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 16, 2024 •
edited
Loading

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: a759326
Status: ✅  Deploy successful!
Preview URL: https://562b18bc.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-custom-items.js-sdk-toolchain.pages.dev

View logs

cazala added 21 commits December 16, 2024 12:45
@cazala
feat: create custom item
2aa7333
@cazala
fix: exclude editor components
588ab22
@cazala
fix: add children to composite
22c862d
@cazala
fix: map resources from within actions
52626c4
@cazala
feat: support mapping resources from deeper properties like the case …
dc0a811 
…of material
@cazala
feat: replace ids with {self} notation
97e0f97
@cazala
fix: make a deep copy of component value
20db594
@cazala
feat: read custom items from data-layer and render tab
23a5bbd
@cazala
feat: instance custom assets
6322a93
@cazala
fix: component value key
c906a5d
@cazala
fix: map ids with multiple entities
6d27e50
@cazala
fix: preserve names
03843bf
@cazala
chore: remove debuggers
51a4746
@cazala
fix: use addChild to set unique name
f710e70
@cazala
fix: styles
9229bbd
@cazala
feat: delete custom asset
e11c143
@cazala
fix: allow writing over empty item
9ff710e
@cazala
feat: custom component and icon
ed57ef7
@cazala
fix: enable tween component
5101748
@cazala
feat: show instance of in entity header
e8dad99
@cazala
fix: include resources loaded by GLTF into the custom asset package
448a5d8
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/custom-items/dcl-sdk-7.6.8-12437437280.commit-7869213.tgz"

  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/custom-items/dcl-sdk-commands-7.6.8-12437437280.commit-7869213.tgz"
npx $SDK_COMMANDS init

  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/custom-items/@dcl/inspector/dcl-inspector-7.6.8-12437437280.commit-7869213.tgz"

  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/custom-items-e2e

  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/custom-items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cazala