Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add enter/leave helpers and UI map #1040

Merged
merged 8 commits into from
Dec 16, 2024
Merged

Conversation

leanmendoza
Copy link
Contributor

@leanmendoza leanmendoza commented Nov 28, 2024

What?

Add support to onMouseEnter={} and onMouseLeave={} in the UI components

Copy link

cloudflare-workers-and-pages bot commented Nov 28, 2024

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: d9447af
Status: ✅  Deploy successful!
Preview URL: https://396c5326.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-add-mouse-enter-leave-u.js-sdk-toolchain.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Nov 28, 2024

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/add-mouse-enter-leave-ui/dcl-sdk-7.6.8-12354680432.commit-d13a093.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/add-mouse-enter-leave-ui/dcl-sdk-commands-7.6.8-12354680432.commit-d13a093.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/add-mouse-enter-leave-ui/@dcl/inspector/dcl-inspector-7.6.8-12354680432.commit-d13a093.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/add-mouse-enter-leave-ui-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/add-mouse-enter-leave-ui

@pravusjif pravusjif requested a review from gonpombo8 November 28, 2024 12:31
@gonpombo8 gonpombo8 enabled auto-merge (squash) December 13, 2024 19:10
@gonpombo8 gonpombo8 merged commit 0c727b8 into main Dec 16, 2024
8 checks passed
@gonpombo8 gonpombo8 deleted the feat/add-mouse-enter-leave-ui branch December 16, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants