Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move alpha_texture from PBRMaterial to UnlitMaterial #1019

Conversation

AlejandroAlvarezMelucciDCL
Copy link
Contributor

@AlejandroAlvarezMelucciDCL AlejandroAlvarezMelucciDCL commented Oct 17, 2024

Addresses the SDK part of issue #240

Related PRs:
E@: decentraland/unity-explorer#2482
Protocol: decentraland/protocol#223

@AlejandroAlvarezMelucciDCL AlejandroAlvarezMelucciDCL marked this pull request as draft October 17, 2024 12:58
Copy link

cloudflare-workers-and-pages bot commented Oct 17, 2024

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: 79972ef
Status: ✅  Deploy successful!
Preview URL: https://29988a0a.js-sdk-toolchain.pages.dev
Branch Preview URL: https://chore-move-alphatexture-from.js-sdk-toolchain.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Oct 17, 2024

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/move-alphaTexture-from-PBRMaterial-to-UnlitMaterial/dcl-sdk-7.6.3-11407293123.commit-683d0d0.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/move-alphaTexture-from-PBRMaterial-to-UnlitMaterial/dcl-sdk-commands-7.6.3-11407293123.commit-683d0d0.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/move-alphaTexture-from-PBRMaterial-to-UnlitMaterial/@dcl/inspector/dcl-inspector-7.6.3-11407293123.commit-683d0d0.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/chore/move-alphaTexture-from-PBRMaterial-to-UnlitMaterial-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=chore/move-alphaTexture-from-PBRMaterial-to-UnlitMaterial

Copy link
Member

@pravusjif pravusjif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The lint has to be fixed
  • Remember to correct the protocol package before merging this PR (After the protocol PR is merged)

@AlejandroAlvarezMelucciDCL AlejandroAlvarezMelucciDCL merged commit d9e3bec into main Oct 18, 2024
8 checks passed
@AlejandroAlvarezMelucciDCL AlejandroAlvarezMelucciDCL deleted the chore/move-alphaTexture-from-PBRMaterial-to-UnlitMaterial branch October 18, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants