fix: use cjs only for export and add types #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates this module to use the [latest pattern for chai plugins](https://www.chaijs.com/guide/plugins/) - the previous pattern causes problems with modern bundlers as it tries to support cjs, amd and script tags in one file. Also adds the types from the DefinitleyTyped project so users don't have to include extra deps to use this module. Also, also upgrades all deps and fixes the new linting errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates this module to use the latest pattern for chai plugins
it tries to support cjs, amd and script tags in one file.
Also adds the types from the DefinitleyTyped project so users don't
have to include extra deps to use this module.
Also, also upgrades all deps and fixes the new linting errors.