-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use and append existing compile flags #19
Conversation
Also fixed the elixir compilation failure :
The error message is misleading - actual problem is that the makefile is in the c_src directory - setting the parameter 'make_cwd' to "c_src" correctly points it to the Makefile in that directory. |
Also with regard to the Travis failure - I'm seeing the same kind of error accross a slew of Erlang/Elixir projects - suggest we ignore the erlang 18 fail. |
@deadtrickster @happysalada - you like ? |
Hi, I do indeed. Can you please remove OTP 18 then? Really love green builds |
Yeah travis update your erlang versions list once in a while pleaze ! https://twitter.com/binarytemple/status/1170651866767736833
@deadtrickster Completed - with regards - tya brah |
Thanks, will push to hex sometime soon |
Fix for : #17
If the system has overridden LDFLAGS - for example, because of a non-standard homebrew install location - then the LDFLAGS flag will not be set correctly (-arch x86_64).
This patch appends the build specific settings, meaning the existing system overrides will be respected.
Personally, I'd leave the optimisation settings (-O3) to the users discression, but that's unimportant for this fix.