Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use and append existing compile flags #19

Merged
merged 4 commits into from
Sep 9, 2019

Conversation

ghost
Copy link

@ghost ghost commented Sep 8, 2019

Fix for : #17

If the system has overridden LDFLAGS - for example, because of a non-standard homebrew install location - then the LDFLAGS flag will not be set correctly (-arch x86_64).

This patch appends the build specific settings, meaning the existing system overrides will be respected.

Personally, I'd leave the optimisation settings (-O3) to the users discression, but that's unimportant for this fix.

@ghost
Copy link
Author

ghost commented Sep 8, 2019

Also fixed the elixir compilation failure :

/code/common/horde_test/ DEBUG=1 mix compile                                                                                                                                      
==> prometheus_process_collector                                                                                                                                                  
make: *** No targets specified and no makefile found.  Stop.                                                                                                                      
could not compile dependency :prometheus_process_collector, "mix compile" failed. You can recompile this dependency with "mix deps.compile prometheus_process_collector", update it with "mix deps.update prometheus_process_collector" or clean it with "mix deps.clean prometheus_process_collector"                                                              
==> horde_test                                                                                                                                                                    
** (Mix) Could not compile with "make" (exit status: 2).                                                                                                                          
You need to have gcc and make installed. Try running the                                                                                                                          
commands "gcc --version" and / or "make --version". If these programs                                                                                                             
are not installed, you will be prompted to install them.

The error message is misleading - actual problem is that the makefile is in the c_src directory - setting the parameter 'make_cwd' to "c_src" correctly points it to the Makefile in that directory.

@ghost
Copy link
Author

ghost commented Sep 8, 2019

Also with regard to the Travis failure - I'm seeing the same kind of error accross a slew of Erlang/Elixir projects - suggest we ignore the erlang 18 fail.

https://twitter.com/binarytemple/status/1170617945208381441

@ghost
Copy link
Author

ghost commented Sep 9, 2019

@deadtrickster @happysalada - you like ?

@deadtrickster
Copy link
Owner

Hi, I do indeed. Can you please remove OTP 18 then? Really love green builds

Yeah travis update your erlang versions list once in a while pleaze ! https://twitter.com/binarytemple/status/1170651866767736833
@ghost
Copy link
Author

ghost commented Sep 9, 2019

Hi, I do indeed. Can you please remove OTP 18 then? Really love green builds

@deadtrickster Completed - with regards - tya brah

@deadtrickster deadtrickster merged commit b852fdc into deadtrickster:master Sep 9, 2019
@deadtrickster
Copy link
Owner

Thanks, will push to hex sometime soon

@ghost ghost deleted the feature/fix-cflags branch September 9, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant