Allow Snitcher.snitch to take a block #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Don't override manually set status/message. - Better message - Re-raise the error - Add some docs
gaffneyc
requested changes
Jan 30, 2024
Co-authored-by: Chris Gaffney <[email protected]>
Ensure snitch with a block raises an error in a block, but hides an error with the snitch processing.
|
Ok, I have this how I think it should be working. Messier than I'd like. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was moving some stuff into Ruby that was previously using Field Agent. I found myself wanting a block syntax to mimic the niceties of Field Agent.
This could be enough, but tracking the duration would be a nice extra. Anything else it should do?
If you manually set an error message and a status, should those take priority? Easy enough to change those to
||=.