Skip to content

Commit

Permalink
Revert the update change since that needs to be in a separate release
Browse files Browse the repository at this point in the history
  • Loading branch information
ddworken committed Oct 20, 2024
1 parent 8bb87f2 commit 8834eac
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions client/cmd/install.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ var (
offlineInstall *bool
skipConfigModification *bool
skipUpdateConfigModification *bool

//lint:ignore U1000 Flag that is allowed to be specified, but not used
currentlyInstalledVersion *string
)

var installCmd = &cobra.Command{
Expand Down Expand Up @@ -688,4 +691,5 @@ func init() {
offlineInstall = installCmd.Flags().Bool("offline", false, "Install hiSHtory in offline mode with all syncing capabilities disabled")
skipConfigModification = installCmd.Flags().Bool("skip-config-modification", false, "Skip modifying shell configs and instead instruct the user on how to modify their configs")
skipUpdateConfigModification = installCmd.Flags().Bool("skip-update-config-modification", false, "Skip modifying shell configs for updates")
currentlyInstalledVersion = installCmd.Flags().String("currently-installed-version", "", "The currently installed version (used by the update command)")
}
2 changes: 1 addition & 1 deletion client/cmd/update.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ func update(ctx context.Context) error {
if err != nil {
return fmt.Errorf("failed to chmod +x the update (stdout=%#v, stderr=%#v): %w", stdout.String(), stderr.String(), err)
}
cmd = exec.Command(getTmpClientPath(), "install", "--skip-update-config-modification")
cmd = exec.Command(getTmpClientPath(), "install")
cmd.Stdout = os.Stdout
stderr = bytes.Buffer{}
cmd.Stdin = os.Stdin
Expand Down

0 comments on commit 8834eac

Please sign in to comment.