Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pulling out and processing the current tries value before the next increment #19

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nhkhai
Copy link

@nhkhai nhkhai commented Feb 18, 2021

Added the param tries_function that takes in an function which can be used to print out or modify the current tries value (before the next increment).

Added the param tries_function that takes in an function which can be used to print out or modify the current tries value (before the next increment).
Reverted case.
@ddmee
Copy link
Owner

ddmee commented Feb 28, 2021

hi nkkhai, thanks for the PR. I've just seen this PR. Looks interesting. I think I can understand why a tries_function would be useful. Can you add a unit test to show me why someone would want to use a tries_function? That would help justify the change as helpful and also make sure the test coverage is continued.

If you don't want to do that, that's cool. But could you please provide me an example of when this new parameter would be useful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants