Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more conventional MIT license form #17

Merged
merged 2 commits into from
Dec 31, 2024

Conversation

obscurerichard
Copy link
Contributor

@obscurerichard obscurerichard commented Dec 5, 2024

I had steered @dcycle towards this license choice (#16) using https://github.com/intel352/vagrant-shell-scripts/blob/master/LICENSE.md as a sample to adapt, however it is formatted unconventionally and the licensee license detector GitHub uses does not identify it properly. So alas, GitHub didn't identify the license as MIT automatically. Sorry about that!

image

Instead, use a version derived directly from the text in https://opensource.org/license/mit

(also specify the copyright date of original publication per trijezdci's answer to the question Do copyright dates need to be updated?)

Test

$ git log -1
commit bc21b834d6deb74e7446a5bf0d8afee573e40cf3 (HEAD -> master, upstream/master, upstream/HEAD)
Author: Albert Albala <[email protected]>
Date:   Sun Dec 1 12:47:18 2024 -0500

    #16 Create LICENSE.md
$ licensee
License:        NOASSERTION
Matched files:  LICENSE.md
LICENSE.md:
  Content hash:  0ff336b75323d180cd64342215d6c81f8e8deb0e
  License:       NOASSERTION
  Closest non-matching licenses:
    MIT similarity:    96.37%
    MIT-0 similarity:  73.68%
    NCSA similarity:   58.47%
$ git checkout fix-mit-license
Switched to branch 'fix-mit-license'
Your branch is up to date with 'origin/fix-mit-license'.
$ licensee
License:        MIT
Matched files:  LICENSE.md
LICENSE.md:
  Content hash:  4c2c763d64bbc7ef2e58b0ec6d06d90cee9755c9
  Attribution:   Copyright (c) 2019 Albert Albala
  Confidence:    100.00%
  Matcher:       Licensee::Matchers::Exact
  License:       MIT

I had steered the author of this towards
https://github.com/intel352/vagrant-shell-scripts/blob/master/LICENSE.md

but it is formatted unconventionally and the license detector
GitHub uses does not identify it properly.

Instead, use a version derived directly from the text in

https://opensource.org/license/mit
I like the instructions in https://stackoverflow.com/a/2391555/424301 and
think the advice is sound
@alberto56 alberto56 merged commit 6bf6399 into dcycle:master Dec 31, 2024
1 check passed
@alberto56
Copy link
Contributor

Thanks! This is now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants