#319 : Empty property value is not invalid + test.

dcoraboeuf · May 8, 2014 · 97505d7 · 97505d7
1 parent c85b43c
commit 97505d7
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/...main/java/net/ontrack/extension/api/property/AbstractLinkPropertyExtensionDescriptor.java b/...main/java/net/ontrack/extension/api/property/AbstractLinkPropertyExtensionDescriptor.java
@@ -2,6 +2,7 @@
 
 import net.ontrack.core.support.InputException;
 import net.sf.jstring.Strings;
+import org.apache.commons.lang3.StringUtils;
 
 import java.net.MalformedURLException;
 import java.net.URI;
@@ -24,6 +25,11 @@ protected AbstractLinkPropertyExtensionDescriptor(String nameKey, String iconNam
      */
     @Override
     public void validate(String value) throws InputException {
+        // Empty value is allowed for property deletion
+        if(StringUtils.isEmpty(value)) {
+            return;
+        }
+
         try {
             // URI validation
             new URI(value);

diff --git a/.../java/net/ontrack/extension/api/property/AbstractLinkPropertyExtensionDescriptorTest.java b/.../java/net/ontrack/extension/api/property/AbstractLinkPropertyExtensionDescriptorTest.java
@@ -42,4 +42,10 @@ public void validate_ok() {
         descriptor.validate(link);
     }
 
+    @Test
+    public void validate_empty_ok() {
+        String link = "";
+        descriptor.validate(link);
+    }
+
 }