Support s2k_fo #115
Open
Support s2k_fo #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @trevormcclellan , thank you for your work. Can you perhaps go into a little more detail here? I don't understand the problem and the effects. What does this commit solve? Is there possibly a bug entry at pypush (the code is not mine)? Kind Regards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever reason, the server always selects s2k_fo as the protocol in the first stage of authentication. The code had a note saying that it only supports s2k, so I added support for s2k_fo. The only difference is that s2k expects a SHA-256 digest of the password, while s2k_fo expects a UTF-8 Hex String of the SHA-256 digest (which I figured out from here: https://github.com/ionescu007/Blackwood-4NT?tab=readme-ov-file#protocols-supported).