Fix warnings.

dchapyshev · Oct 29, 2023 · ba21379 · ba21379
1 parent 59f2ef4
commit ba21379
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 9 deletions.
diff --git a/source/base/audio/audio_output_win.cc b/source/base/audio/audio_output_win.cc
@@ -188,7 +188,7 @@ void AudioOutputWin::threadRun()
     {
         // Wait for a close-down event, stream-switch event or a new render event.
         DWORD wait_result = WaitForMultipleObjects(
-            std::size(wait_array), wait_array, false, INFINITE);
+            static_cast<DWORD>(std::size(wait_array)), wait_array, false, INFINITE);
         switch (wait_result)
         {
             case WAIT_OBJECT_0 + 0:

diff --git a/source/base/audio/win/audio_util_win.cc b/source/base/audio/win/audio_util_win.cc
@@ -326,7 +326,7 @@ bool isMMCSSSupported()
     static const wchar_t* const kAvrtDLL = L"%WINDIR%\\system32\\Avrt.dll";
     wchar_t path[MAX_PATH] = { 0 };
 
-    ExpandEnvironmentStringsW(kAvrtDLL, path, std::size(path));
+    ExpandEnvironmentStringsW(kAvrtDLL, path, static_cast<DWORD>(std::size(path)));
     return (LoadLibraryExW(path, nullptr, LOAD_WITH_ALTERED_SEARCH_PATH) != nullptr);
 }
 

diff --git a/source/base/codec/multi_channel_resampler.cc b/source/base/codec/multi_channel_resampler.cc
@@ -47,7 +47,7 @@ MultiChannelResampler::MultiChannelResampler(int channels,
     }
 
     // Setup the wrapped AudioBus for channel data.
-    wrapped_resampler_audio_bus_->set_frames(request_size);
+    wrapped_resampler_audio_bus_->set_frames(static_cast<int>(request_size));
 
     // Allocate storage for all channels except the first, which will use the
     // |destination| provided to ProvideInput() directly.

diff --git a/source/base/codec/zstd_compress.cc b/source/base/codec/zstd_compress.cc
@@ -32,7 +32,7 @@ const uint32_t kMaxDataSize = 64 * 1024 * 1024; // 64 MB
 template <class T>
 T compressT(const T& source, int compress_level)
 {
-    uint32_t source_data_size = source.size();
+    uint32_t source_data_size = static_cast<uint32_t>(source.size());
     if (!source_data_size || source_data_size > kMaxDataSize)
     {
         LOG(LS_ERROR) << "Invalid source data size: " << source_data_size;

diff --git a/source/base/logging.cc b/source/base/logging.cc
@@ -264,7 +264,7 @@ std::filesystem::path execFilePath()
 
 #if defined(OS_WIN)
     wchar_t buffer[MAX_PATH] = { 0 };
-    GetModuleFileNameExW(GetCurrentProcess(), nullptr, buffer, std::size(buffer));
+    GetModuleFileNameExW(GetCurrentProcess(), nullptr, buffer, static_cast<DWORD>(std::size(buffer)));
     exec_file_path = buffer;
 #elif defined(OS_LINUX)
     char buffer[PATH_MAX] = { 0 };
@@ -472,7 +472,7 @@ LogMessage::~LogMessage()
     {
         std::scoped_lock lock(g_log_file_lock);
 
-        if (g_log_file.tellp() >= g_max_log_file_size)
+        if (static_cast<size_t>(g_log_file.tellp()) >= g_max_log_file_size)
         {
             // The maximum size of the log file has been exceeded. Close the current log file and
             // create a new one.

diff --git a/source/base/system_error.cc b/source/base/system_error.cc
@@ -73,8 +73,8 @@ std::string SystemError::toString(Code code)
     constexpr int kErrorMessageBufferSize = 256;
     wchar_t msgbuf[kErrorMessageBufferSize];
 
-    DWORD len = FormatMessageW(FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_IGNORE_INSERTS,
-                               nullptr, code, 0, msgbuf, std::size(msgbuf), nullptr);
+    DWORD len = FormatMessageW(FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_IGNORE_INSERTS, nullptr,
+                               code, 0, msgbuf, static_cast<DWORD>(std::size(msgbuf)), nullptr);
     if (len)
     {
         std::wstring msg = collapseWhitespace(msgbuf, true) + stringPrintf(L" (0x%lX)", code);

diff --git a/source/base/win/registry_unittest.cc b/source/base/win/registry_unittest.cc
@@ -191,7 +191,8 @@ TEST_F(RegistryTest, TruncatedCharTest)
     // kData size is not a multiple of sizeof(wchar_t).
     const uint8_t kData[] = { 1, 2, 3, 4, 5 };
     EXPECT_EQ(5u, std::size(kData));
-    ASSERT_EQ(ERROR_SUCCESS, key.writeValue(kName, kData, std::size(kData), REG_BINARY));
+    ASSERT_EQ(ERROR_SUCCESS,
+        key.writeValue(kName, kData, static_cast<DWORD>(std::size(kData)), REG_BINARY));
 
     RegistryValueIterator iterator(HKEY_CURRENT_USER, foo_key.c_str());
     ASSERT_TRUE(iterator.valid());