Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derive Copy for types based on fixed-len arrays #268

Merged
merged 3 commits into from
Oct 23, 2023
Merged

Derive Copy for types based on fixed-len arrays #268

merged 3 commits into from
Oct 23, 2023

Conversation

oskin1
Copy link
Contributor

@oskin1 oskin1 commented Oct 13, 2023

Duplicate of #257

@rooooooooob
Copy link
Contributor

I'm not sure why the CI job run is failing. I can't reproduce it locally with the same command, and the clippy error doesn't make much sense as both PartialOrd/Ord are derived, albeit using the derivative crate. There doesn't seem to be any new version of the derivative crate possibly causing different behavior between the CI task and locally.

Either way it's definitely not related to this PR as it's happening in my other open PR but the last few merged PRs had their CI jobs complete just fine.

@rooooooooob
Copy link
Contributor

I put up a PR #269 that should fix it. I'll try and get it merged then rerun the check here and if it passes (it failing prevented a bunch of other later checks from running in this PR) I'll merge this.

@rooooooooob
Copy link
Contributor

@oskin1 I think you'll need to merge the latest develop into your branch to have the CI get passed that issue. I tried just making the CI run again but it still fails. I would just LGTM it and merge it but it would be good to make sure that all the other tests in the CI pass.

@oskin1 oskin1 force-pushed the copy-fix-len-array-2 branch from 6b025a9 to 4a506b6 Compare October 20, 2023 13:06
@oskin1
Copy link
Contributor Author

oskin1 commented Oct 20, 2023

@rooooooooob rebased on top of develop

rooooooooob
rooooooooob approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@rooooooooob rooooooooob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution!

@rooooooooob rooooooooob merged commit 71d6dc9 into dcSpark:develop Oct 23, 2023
1 check passed
rooooooooob added a commit that referenced this pull request Oct 24, 2023
@rooooooooob
Fix clippy after merging #268
93a67f9
gostkin pushed a commit that referenced this pull request Oct 31, 2023
@rooooooooob
Conway cert builder support (#270)
6102d5c 
* Conway cert builder support

support for adding conway certs to txs with support for deposit
calculation

also fixes NetworkId bug

* add vkeys to add_cert_vkeys()

* Fix clippy after merging #268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rooooooooob rooooooooob rooooooooob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oskin1 @rooooooooob