Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate manifest for dbt-core#9199 #38

Merged
merged 1 commit into from
May 2, 2024

Conversation

jtcohen6
Copy link
Collaborator

@jtcohen6 jtcohen6 commented May 2, 2024

This diff correctly reflects two changes in dbt-labs/dbt-core#9199:

  • defer: bool is being removed from serialized WritableManifest
  • DeferRelation (which is not included in WritableManifest) includes additional fields, encouraged by RelationConfig protocol, to provide a consistent interface for BaseRelation.create_from

@jtcohen6 jtcohen6 requested a review from aranke May 2, 2024 11:10
Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after offline visual inspection.

Base automatically changed from jerco/update-manifest-v12-2024-05-01 to main May 2, 2024 13:18
@jtcohen6 jtcohen6 force-pushed the jerco/update-manifest-for-core#9199 branch from 86c6a56 to 61225d1 Compare May 2, 2024 13:27
@jtcohen6 jtcohen6 merged commit f308c33 into main May 2, 2024
5 checks passed
@jtcohen6 jtcohen6 deleted the jerco/update-manifest-for-core#9199 branch May 2, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants