Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conditional execution on populate schema action #998

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

tlento
Copy link
Contributor

@tlento tlento commented Jan 26, 2024

The populate persistent source schema GitHub action has a
workflow_dispatch trigger, but when you attempt to use it all
actions are immediately skipped.

This makes the changes necessary to enable the workflow_dispatch
trigger to execute the tasks in this workflow.

@tlento tlento force-pushed the fix-execution-check-on-populate-schema-action branch from 1d84218 to 6531931 Compare January 26, 2024 00:50
@tlento tlento had a problem deploying to DW_INTEGRATION_TESTS January 26, 2024 00:52 — with GitHub Actions Error
@tlento tlento had a problem deploying to DW_INTEGRATION_TESTS January 26, 2024 00:52 — with GitHub Actions Error
@tlento tlento had a problem deploying to DW_INTEGRATION_TESTS January 26, 2024 00:52 — with GitHub Actions Error
@tlento tlento had a problem deploying to DW_INTEGRATION_TESTS January 26, 2024 00:52 — with GitHub Actions Error
@tlento
Copy link
Contributor Author

tlento commented Jan 26, 2024

Workflow dispatch run: https://github.com/dbt-labs/metricflow/actions/runs/7662451871
Labeled run: https://github.com/dbt-labs/metricflow/actions/runs/7662480501/job/20883774341?pr=998

Note the workflow dispatch run was canceled when I deployed the engine tests, but that deployment confirmed that the reload tests updated here were appropriately skipped when I added the engine tests label.

@tlento tlento added the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Jan 26, 2024
@tlento tlento had a problem deploying to DW_INTEGRATION_TESTS January 26, 2024 00:54 — with GitHub Actions Failure
@tlento tlento had a problem deploying to DW_INTEGRATION_TESTS January 26, 2024 00:54 — with GitHub Actions Failure
@tlento tlento had a problem deploying to DW_INTEGRATION_TESTS January 26, 2024 00:54 — with GitHub Actions Failure
@tlento tlento had a problem deploying to DW_INTEGRATION_TESTS January 26, 2024 00:54 — with GitHub Actions Failure
@tlento tlento added Reload Test Data in SQL Engines Should be run when test data changes and removed Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment labels Jan 26, 2024
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS January 26, 2024 00:56 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS January 26, 2024 00:56 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS January 26, 2024 00:56 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS January 26, 2024 00:56 — with GitHub Actions Inactive
@github-actions github-actions bot removed the Reload Test Data in SQL Engines Should be run when test data changes label Jan 26, 2024
@cla-bot cla-bot bot added the cla:yes label Jan 26, 2024
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS January 26, 2024 01:05 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS January 26, 2024 01:05 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS January 26, 2024 01:05 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS January 26, 2024 01:05 — with GitHub Actions Inactive
The populate persistent source schema GitHub action has a
workflow_dispatch trigger, but when you attempt to use it all
actions are immediately skipped.

This makes the changes necessary to enable the workflow_dispatch
trigger to execute the tasks in this workflow.
@tlento tlento marked this pull request as ready for review January 26, 2024 01:10
@tlento tlento force-pushed the fix-execution-check-on-populate-schema-action branch from b5a6630 to cb73c0c Compare January 26, 2024 01:16
Copy link
Contributor Author

tlento commented Jan 26, 2024

@tlento tlento force-pushed the fix-execution-check-on-populate-schema-action branch from cb73c0c to 6d0062e Compare January 26, 2024 01:24
Databricks and BigQuery are super slow on data load, which leaves
us wondering if they're doing anything. Without a log-cli-level set
the action logs just sit for a good 3 minutes. This adds log-cli-level
info to the command in order to provide some more detail on what the
actions are doing, which will also be helpful if something should fail.
@tlento tlento force-pushed the fix-execution-check-on-populate-schema-action branch from 6d0062e to 163b3c8 Compare January 26, 2024 01:29
@tlento tlento merged commit 2d8c76e into main Jan 26, 2024
10 checks passed
@tlento tlento deleted the fix-execution-check-on-populate-schema-action branch January 26, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants