Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose min_max_only param on explain_get_dimension_values #989

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Expose min_max_only param on explain_get_dimension_values #989

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions metricflow/engine/metricflow_engine.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -683,6 +683,7 @@ def explain_get_dimension_values( # noqa: D
group_by: Optional[GroupByParameter] = None,
time_constraint_start: Optional[datetime.datetime] = None,
time_constraint_end: Optional[datetime.datetime] = None,
min_max_only: bool = False,
) -> MetricFlowExplainResult:
assert not (
get_group_by_values and group_by
Expand All @@ -695,6 +696,7 @@ def explain_get_dimension_values( # noqa: D
group_by=(group_by,) if group_by else None,
time_constraint_start=time_constraint_start,
time_constraint_end=time_constraint_end,
min_max_only=min_max_only,
query_type=MetricFlowQueryType.DIMENSION_VALUES,
)
)