Remove unused numpy dependency #984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
1 similar comment
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
tlento
force-pushed
the
remove-numpy-dependency
branch
from
fc6094e to
f0695b9
Compare
Licensing analysis tripped a potential issue with numpy. The thing is we don't use numpy for anything - this dependency is only here because some past transitive dependency caused issues with M1 macs and pinning a minimum version for numpy ensured that particular problem would not come up. Even the initial addition was to pin past some security patch. Wild. Anyway, rather than try to figure out if the new licensing issue is a false positive, I'm simply removing the package from our linked dependency set.
tlento
force-pushed
the
remove-numpy-dependency
branch
from
f0695b9 to
790b709
Compare
courtneyholcomb
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Licensing analysis tripped a potential issue with numpy. The
thing is we don't use numpy for anything - this dependency is
only here because some past transitive dependency caused issues
with M1 macs and pinning a minimum version for numpy ensured
that particular problem would not come up. Even the initial
addition was to pin past some security patch. Wild.
Anyway, rather than try to figure out if the new licensing
issue is a false positive, I'm simply removing the package from
our linked dependency set.