Test fix: Rename primary entity to one that doesn't exist already #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
1 similar comment
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
courtneyholcomb
changed the title
courtneyholcomb
force-pushed
the
court/revenue-fixture
branch
from
8072cf1 to
a609f54
Compare
WilliamDee
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates one of our test fixtures. The
revenuesemantic model had itsprimary_entitydefined ascustomer, even thoughcustomeris an entity in a different semantic model. Therevenuesemantic model does not have a primary key to reference, in which case we want to giveprimary_entitya unique name. The entity isn't queryable, but it will be the prefix used to reference dimensions from that semantic model.Not attached to the name
revenue_instancebut it was the best of what I came up with.