Improve DAG Text Formatting #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plypaul
added
the
Run Tests With Other SQL Engines
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
courtneyholcomb
approved these changes
Jan 16, 2024
| <!-- from_source = SqlSelectStatementNode(node_id=ss_10) --> | ||
| <!-- where = None --> | ||
| <!-- distinct = False --> | ||
| <SqlSelectStatementNode> | ||
| <!-- description = Pass Only Elements: ['visits',] --> | ||
| <!-- node_id = ss_10 --> | ||
| <!-- description = "Pass Only Elements: ['visits',]" --> |
There was a problem hiding this comment.
Should we default to double quotes for these descriptions for better consistency? Not a strong opinion here.
There was a problem hiding this comment.
Do you mean how it uses " in some cases but ' in others? It seems that's the behavior of repr() / pprint.pformat() if it's a string or a string containing a quote.
plypaul
force-pushed
the
plypaul--75--mf-format-snapshots
branch
2 times, most recently
from
ff71ec2 to
9b9bb09
Compare
plypaul
force-pushed
the
plypaul--83--improve-dag-formatting
branch
from
bd04368 to
fc4fe7b
Compare
tlento
reviewed
Jan 20, 2024
| @@ -111,6 +112,10 @@ def accept_dag_node_visitor(self, visitor: DagNodeVisitor[VisitorOutputT]) -> Vi | |||
| """Visit this node.""" | |||
| return visitor.visit_node(self) | |||
|
|
|||
| def text_structure(self, formatter: MetricFlowDagTextFormatter = MetricFlowDagTextFormatter()) -> str: | |||
There was a problem hiding this comment.
This change warms my cold grinchy heart....
plypaul
force-pushed
the
plypaul--83--improve-dag-formatting
branch
from
fc4fe7b to
89d5fe4
Compare
plypaul
added
the
Run Tests With Other SQL Engines
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
This adds a .text_structure() to the DAG classes for easier conversion to a text representation.
These are no longer necessary as the DAG classes now have a .text_structure().
This updates the logic for how max with is tracked / handled when recursively formatting a DAG to properly handle the indented / recursive case.
mf_pformat_many() makes the log look a little odd as it logs repr(str) instead of str.
plypaul
force-pushed
the
plypaul--83--improve-dag-formatting
branch
from
89d5fe4 to
3d3d82a
Compare
plypaul
added
the
Run Tests With Other SQL Engines
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
plypaul
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
Dag.text_structure() / DagNode.text_structure()to make it easier to generate the text representation of a DAG.