Fix duplicate input measures error #968
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #969
Description
Currently, when running through the branch combiner, in an instance where you have 2 derived metrics that contains the same input measure, it would get combined and it doesn't get deduped. Example,
This leads to hitting an error during the dataflow rendering where we matched 2 duplicate input measures when expecting only 1 (here). Additionally, the parser in dbt-core utilizes it's own rewritten set of transformation rules and it currently isn't doing any deduping, this is a bug and should be fixed within dbt-core, tho it isn't affecting this issue.
NOTE: this error only occurs from manifests parsed by dbt-core, which is why the error never popped up in MF as MF uses the transformation rules in DSI.