Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand MetricFlowEngine Initializer Signature #961

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

plypaul
Copy link
Contributor

@plypaul plypaul commented Jan 5, 2024

Resolves #

Description

This PR updates the initializer for MetricFlowEngine to allow a query parser to be passed in. A different query parser can be used to alter how inputs to the engine are handled.

@cla-bot cla-bot bot added the cla:yes label Jan 5, 2024
@plypaul plypaul force-pushed the plypaul--77--duplicate-resolution branch from e4f7816 to 068d398 Compare January 5, 2024 17:26
@plypaul plypaul force-pushed the plypaul--78--adjust-engine-interface branch from 384e04e to a187edf Compare January 5, 2024 17:28
@plypaul plypaul marked this pull request as ready for review January 5, 2024 17:43
Copy link
Contributor

@courtneyholcomb courtneyholcomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! THANK YOU for the quick turnaround! 🙏

Base automatically changed from plypaul--77--duplicate-resolution to main January 5, 2024 19:45
@plypaul plypaul force-pushed the plypaul--78--adjust-engine-interface branch from a187edf to bd9798d Compare January 5, 2024 19:45
@plypaul plypaul merged commit 3b36c4c into main Jan 5, 2024
9 checks passed
@plypaul plypaul deleted the plypaul--78--adjust-engine-interface branch January 5, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants