Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for adding and evaluating test runs for #810 #942

Closed
wants to merge 7 commits into from

Conversation

tlento
Copy link
Contributor

@tlento tlento commented Dec 16, 2023

Initial PR has been squashed to a single commit. Additional test updates to follow.

lint

Handle timestamp literals for range operator

Update test cases to handle group by for Trino in metrics calculation

Handle dry run and approx percentile for Trino along with more explicit castings

Add changelog

Fix percentile function and rename sqltimedelta function in Trino client

Handle extract for Trino

fix lint issues

Fix additional test case snapshots related to extract function

Use positional arguments in group by to fix tests

Fix time delta expression for Trino and regenerate snapshot

Add trino to cd-sql-engine-tests

Address function inline comments

bump version for dependencies
@tlento tlento added the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Dec 16, 2023
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS December 16, 2023 02:05 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS December 16, 2023 02:05 — with GitHub Actions Inactive
@tlento tlento had a problem deploying to DW_INTEGRATION_TESTS December 16, 2023 02:05 — with GitHub Actions Failure
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS December 16, 2023 02:05 — with GitHub Actions Inactive
@tlento tlento added Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment and removed Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment labels Dec 16, 2023
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS December 16, 2023 02:43 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS December 16, 2023 02:43 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS December 16, 2023 02:43 — with GitHub Actions Inactive
@tlento tlento temporarily deployed to DW_INTEGRATION_TESTS December 16, 2023 02:43 — with GitHub Actions Inactive
@github-actions github-actions bot removed the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Dec 16, 2023
This environment is missing some package installs for SqlAlchemy,
which causes all tests to fail with an import error.
The original setup instructions for local configuration of a
postgres instance for testing pre-dated our cutover to hatch for
environment management. Consequently, there were a number of
inaccuracies in how to use the postgres container once it was up
and running. This commit brings those command examples in line with
our current configuration.
@tlento tlento closed this Dec 19, 2023
@tlento tlento deleted the add-trino-support branch July 19, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants