-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR for adding and evaluating test runs for #810 #942
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lint Handle timestamp literals for range operator Update test cases to handle group by for Trino in metrics calculation Handle dry run and approx percentile for Trino along with more explicit castings Add changelog Fix percentile function and rename sqltimedelta function in Trino client Handle extract for Trino fix lint issues Fix additional test case snapshots related to extract function Use positional arguments in group by to fix tests Fix time delta expression for Trino and regenerate snapshot Add trino to cd-sql-engine-tests Address function inline comments bump version for dependencies
tlento
added
the
Run Tests With Other SQL Engines
Runs the test suite against the SQL engines in our target environment
label
Dec 16, 2023
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
December 16, 2023 02:05 — with
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
December 16, 2023 02:05 — with
GitHub Actions
Inactive
tlento
had a problem deploying
to
DW_INTEGRATION_TESTS
December 16, 2023 02:05 — with
GitHub Actions
Failure
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
December 16, 2023 02:05 — with
GitHub Actions
Inactive
tlento
added
Run Tests With Other SQL Engines
Runs the test suite against the SQL engines in our target environment
and removed
Run Tests With Other SQL Engines
Runs the test suite against the SQL engines in our target environment
labels
Dec 16, 2023
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
December 16, 2023 02:43 — with
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
December 16, 2023 02:43 — with
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
December 16, 2023 02:43 — with
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
December 16, 2023 02:43 — with
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
Runs the test suite against the SQL engines in our target environment
label
Dec 16, 2023
This environment is missing some package installs for SqlAlchemy, which causes all tests to fail with an import error.
The original setup instructions for local configuration of a postgres instance for testing pre-dated our cutover to hatch for environment management. Consequently, there were a number of inaccuracies in how to use the postgres container once it was up and running. This commit brings those command examples in line with our current configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial PR has been squashed to a single commit. Additional test updates to follow.