Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Incorrect Column Name Rendering For WhereConstraintNode #909

Merged
merged 7 commits into from
Nov 28, 2023
Merged

Fix Incorrect Column Name Rendering For WhereConstraintNode #909

merged 7 commits into from
Nov 28, 2023

Conversation

plypaul
Copy link
Contributor

@plypaul plypaul commented Nov 28, 2023 •
edited
Loading

Resolves #908

Description

Please see the associated issue for more details.

@cla-bot cla-bot bot added the cla:yes label Nov 28, 2023
@plypaul plypaul changed the title Fix Incorrect Column Name Rendering For WhereConstraintNode. Fix Incorrect Column Name Rendering For WhereConstraintNode Nov 28, 2023
@plypaul plypaul marked this pull request as ready for review November 28, 2023 22:32
courtneyholcomb
courtneyholcomb approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@courtneyholcomb courtneyholcomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Paul!

@plypaul plypaul force-pushed the plypaul--63--fix-where-node branch from 6624b10 to bc60c7e Compare November 28, 2023 23:09
@plypaul plypaul added the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Nov 28, 2023
@plypaul plypaul temporarily deployed to DW_INTEGRATION_TESTS November 28, 2023 23:09 — with GitHub Actions Inactive
@plypaul plypaul temporarily deployed to DW_INTEGRATION_TESTS November 28, 2023 23:09 — with GitHub Actions Inactive
@plypaul plypaul temporarily deployed to DW_INTEGRATION_TESTS November 28, 2023 23:09 — with GitHub Actions Inactive
@plypaul plypaul temporarily deployed to DW_INTEGRATION_TESTS November 28, 2023 23:09 — with GitHub Actions Inactive
@github-actions github-actions bot removed the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Nov 28, 2023
@plypaul plypaul merged commit 4185513 into main Nov 28, 2023
22 checks passed
@plypaul plypaul deleted the plypaul--63--fix-where-node branch November 28, 2023 23:53
@WilliamDee WilliamDee mentioned this pull request Dec 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@courtneyholcomb courtneyholcomb courtneyholcomb approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SL-1295] [Bug] Incorrect SQL Column Name Rendering for WhereConstraintNode
2 participants
@plypaul @courtneyholcomb