Organize DataflowPlanBuilder Recursive Case Handling #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlento
approved these changes
Nov 16, 2023
| @@ -123,35 +121,6 @@ def configured_input_measure_for_metric(self, metric_reference: MetricReference) | |||
| else: | |||
| assert_values_exhausted(metric.type) | |||
|
|
|||
| def measures_for_metric( | |||
There was a problem hiding this comment.
Oh yeah I think this was used somewhere else, and isn't anymore. Agree it makes more sense in the one place it's used, although making the DataflowPlanBuilder longer is a bit of a bummer.
plypaul
force-pushed
the
plypaul--58.3--assorted-spec-changes
branch
from
a2f779b to
6331dbb
Compare
Base automatically changed from
plypaul--58.3--assorted-spec-changes
to
main
November 16, 2023 04:18
…ookUp.measures_for_metric(). This more cleanly separates the recursive handling of derived metrics into cases: * Build a node to compute a simple / base metric. * Build a node to compute a derived metric. * Build a node to compute a metric of any type. * Build a node to compute many metrics. In addition, this also moves MetricLookUp.measures_for_metric() into the DataflowPlanBuilder because it seemed a little out of place in MetricLookUp due to the dependence on the column association resolver.
plypaul
force-pushed
the
plypaul--58.4--refactor-dfpb
branch
from
0361b0e to
4c6ecb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR separates the recursive handling of derived metrics into cases
using different methods that are shorter / easier to understand:
In addition, this also moves MetricLookUp.measures_for_metric() into the
DataflowPlanBuilder because it seemed a little out of place in MetricLookUp
due to the dependence on the column association resolver.
This is mostly a shuffling of the code w/o logic changes.