Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RudderStack logging from MetricFlow telemetry #866

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

tlento
Copy link
Contributor

@tlento tlento commented Nov 14, 2023

Prior to its acquisition by dbt Labs, Transform used Rudderstack
for analytics event log handling. As a result, the MetricFlow
telemetry system included the option to log data to Rudderstack.

Nowadays there is no longer a need to support this route, and indeed
the Rudderstack client itself causes some small problems, such as
the occasional irrepressible warning about SSL sockets failing
to close properly after running queries in the MetricFlow CLI.

@cla-bot cla-bot bot added the cla:yes label Nov 14, 2023
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@tlento tlento linked an issue Nov 14, 2023 that may be closed by this pull request
Prior to its acquisition by dbt Labs, Transform used Rudderstack
for analytics event log handling. As a result, the MetricFlow
telemetry system included the option to log data to Rudderstack.

Nowadays there is no longer a need to support this route, and indeed
the Rudderstack client itself causes some small problems, such as
the occasional irrepressible warning about SSL sockets failing
to close properly after running queries in the MetricFlow CLI.
@tlento tlento force-pushed the remove-rudderstack-logging branch from 82ca873 to 96d4d5d Compare November 14, 2023 02:15
@tlento tlento marked this pull request as ready for review November 14, 2023 02:15
Copy link
Contributor

@courtneyholcomb courtneyholcomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🪓 🪓 🪓

Copy link
Collaborator

@marcodamore marcodamore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to dust off the old stamp for this one

@tlento tlento merged commit 0d24aee into main Nov 14, 2023
8 checks passed
@tlento tlento deleted the remove-rudderstack-logging branch November 14, 2023 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove rudderstack telemetry handler
3 participants