Fix query validation for metric_time requirements #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
As of right now we require metric_time in the group by expression for any metric query against cumulative metrics or derived metrics with time offset windows or an offset_to_grain parameter set. The current query validation was only asserting that some time dimension was included in the group by. In the case of derived metrics, this simply failed later in the query building phase for any query with a different time dimension in the group by expression. In the case of cumulative metrics, this would run an incorrectly rendered query and then return incorrect results. This validation change ensures that users have the proper configuration on queries based on our current limitations.
tlento
force-pushed
the
fix-metric-time-requirement-validation
branch
from
46f9943 to
362d934
Compare
tlento
added
the
Run Tests With Other SQL Engines
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
WilliamDee
approved these changes
Nov 8, 2023
github-actions
bot
removed
the
Run Tests With Other SQL Engines
Base automatically changed from
expand-cumulative-and-derived-metric-tests
to
main
November 8, 2023 23:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #825
Description
As of right now we require metric_time in the group by expression
for any metric query against cumulative metrics or derived metrics
with time offset windows or an offset_to_grain parameter set.
The current query validation was only asserting that some time
dimension was included in the group by. In the case of derived
metrics, this simply failed later in the query building phase for
any query with a different time dimension in the group by expression.
In the case of cumulative metrics, this would run an incorrectly
rendered query and then return incorrect results.
This validation change ensures that users have the proper
configuration on queries based on our current limitations.