Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move derived metric rendering tests to their own module #838

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

tlento
Copy link
Contributor

@tlento tlento commented Nov 3, 2023

Part 3 of the great effort to split up test_dataflow_to_sql_plan.

Derived metrics are complicated, so they get their own module.

Part 3 of the great effort to split up test_dataflow_to_sql_plan.

Derived metrics are complicated, so they get their own module.
Copy link

github-actions bot commented Nov 3, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@tlento tlento changed the title Move derived metric rendering tests Move derived metric rendering tests to their own module Nov 3, 2023
@tlento tlento marked this pull request as ready for review November 3, 2023 00:34
Base automatically changed from move-cumulative-metric-rendering-tests to main November 3, 2023 01:48
@tlento tlento merged commit 9a871e4 into main Nov 3, 2023
33 of 35 checks passed
@tlento tlento deleted the 11-02-Move_derived_metric_rendering_tests branch November 3, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants