Mark Tests That Generate SQL-Engine-Specific Snapshots #828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plypaul
requested review from
tlento and
courtneyholcomb
and removed request for
tlento
tlento
approved these changes
Oct 30, 2023
| @@ -136,6 +136,7 @@ def convert_and_check( | |||
| ) | |||
|
|
|||
|
|
|||
| @pytest.mark.sql_engine_snapshot | |||
There was a problem hiding this comment.
You can mark the file, actually, but this seems fine to me.
| @@ -261,6 +261,9 @@ def assert_object_snapshot_equal( # type: ignore[misc] | |||
| sql_client: Optional[SqlClient] = None, | |||
| ) -> None: | |||
| """For tests to compare large objects, this can be used to snapshot a text representation of the object.""" | |||
| if sql_client is not None: | |||
| check_sql_engine_snapshot_marker(request) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a custom pytest marker to mark tests that generate SQL-engine-specific snapshots. This helps to ensures that the
generate_snapshots.pyscript generates snapshots for all relevant tests.