Add missing snapshots for saved queries #824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This list was impossible to read through. Now that it's sorted we can find things.
The new saved query CLI tests rely on snapshot generation, but the generate snapshot script will not update them and so our engine tests are difficult to maintain. This adds the relevant tests to the update list and generates the associated snapshot files by way of illustrating that everything works. We might consider moving to a pytest.mark attribute for the modules and test cases that rely on snapshots, but for the time being the list of test paths seems fine.
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
changed the title
courtneyholcomb
approved these changes
Oct 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new saved query CLI tests rely on snapshot generation, but
the generate snapshot script will not update them and so our engine
tests are difficult to maintain.
This adds the relevant tests to the update list and generates the
associated snapshot files by way of illustrating that everything works.
We might consider moving to a pytest.mark attribute for the modules
and test cases that rely on snapshots, but for the time being the list
of test paths seems fine.