Fix broken SQL engine tests #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQL engine test environments do not currently build due to the cutover to dbt-core 1.7.0rc1. Now that the other adapter packages we depend on have a 1.7.0rc1 deployed, we can update our dependencies so that all of these will build and run. The only remaining holdout is duckdb, which we already have running on 1.6.
The distinct values plans could not be updated for Databricks on the final run due to an outage. These were auto-generated via the usual overwrite-snapshots mechanism.
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
tlento
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
tlento
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
tlento
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
tlento
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
tlento
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
For historical reasons we were testing both cluster connection types and sql warehouse connection types. Since cutting our connection management over to dbt adapters and removing all DDL from MetricFlow we no longer need to test in both runtimes, so this removes the cluster connection tests and brings our Databricks environment variable in line with the other engines.
tlento
changed the title
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
tlento
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of our SQL engine tests have been broken for a few days.
This PR addresses both issues and gets everything running again.
See individual commits for details on each necessary fix.