Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dundered granularity syntax with object params #803

Closed
wants to merge 2 commits into from

Conversation

courtneyholcomb
Copy link
Contributor

Description

Allow users to pass dundered granularity syntax even in object parameters. Originally, I intentionally disallowed this. But it creates a weird inconsistency across parameters that users were running into, so it seems better to allow it.

@github-actions
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@tlento
Copy link
Contributor

tlento commented Oct 11, 2023

Ooof, really? I thought we agreed to deprecate this access pattern. The reason it's confusing right now is because sometimes it works and sometimes it doesn't - if it never works, then it will no longer be confusing.

If we allow it everywhere now we live with it forever, and I would dearly love to be rid of it forever instead.

@tlento
Copy link
Contributor

tlento commented Oct 11, 2023

Oh wait actually I remember now, this was an open question and we were leaning towards allowing granularity as a property of the time dimension. So essentially we have dimensions of time dimensions and you can ask for the day/month/year/etc.

The thing is, we don't have a design for that at all. Can we hold off on this for a bit until we have some space to deal with it?

@courtneyholcomb
Copy link
Contributor Author

Oh wait actually I remember now, this was an open question and we were leaning towards allowing granularity as a property of the time dimension. So essentially we have dimensions of time dimensions and you can ask for the day/month/year/etc.

The thing is, we don't have a design for that at all. Can we hold off on this for a bit until we have some space to deal with it?

@tlento Actually, I thought this was needed for a fix in MFS, but turns out it's not. So I'll close it!

@tlento
Copy link
Contributor

tlento commented Oct 11, 2023

@tlento Actually, I thought this was needed for a fix in MFS, but turns out it's not. So I'll close it!

😌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants