Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove query interface #800

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Remove query interface #800

merged 1 commit into from
Oct 10, 2023

Conversation

DevonFulcher
Copy link
Contributor

Description

Remove the query interface and depend on DSIs protocols instead

@cla-bot cla-bot bot added the cla:yes label Oct 6, 2023
@DevonFulcher DevonFulcher temporarily deployed to Pypi Publish October 6, 2023 22:38 — with GitHub Actions Inactive
Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

Copy link
Contributor

@tlento tlento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooooh, there's only one now? Nice!

Copy link
Contributor

@tlento tlento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case it's not clear, I also approve. :)

@DevonFulcher DevonFulcher merged commit 0552bfd into main Oct 10, 2023
22 checks passed
@DevonFulcher DevonFulcher deleted the remove_query_interface branch October 10, 2023 16:11
sarbmeetka pushed a commit to sarbmeetka/metricflow that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants