Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change OrderBySpec to Use a Single Spec #789

Merged
merged 2 commits into from
Oct 5, 2023
Merged

Change OrderBySpec to Use a Single Spec #789

merged 2 commits into from
Oct 5, 2023

Conversation

plypaul
Copy link
Contributor

@plypaul plypaul commented Sep 28, 2023

Description

Thanks to some earlier changes, the OrderBySpec class can be made easier / cleaner to use by having a single InstanceSpec field instead of more concrete types.

@cla-bot cla-bot bot added the cla:yes label Sep 28, 2023
@plypaul plypaul marked this pull request as ready for review September 28, 2023 18:18
@plypaul plypaul requested a review from tlento September 28, 2023 18:18
tlento
tlento approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@tlento tlento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable!

To be honest, I forget why we needed the spec type separation at all, so I'm glad I won't need to wonder about it anymore.

@plypaul plypaul merged commit 5510662 into main Oct 5, 2023
34 checks passed
@plypaul plypaul deleted the plypaul--58.1--singular-spec-field-for-order-by branch October 5, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlento tlento tlento approved these changes

Assignees
No one assigned
Labels
cla:yes Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plypaul @tlento