Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Querying with EXTRACT #770

Closed
wants to merge 15 commits into from
Prev Previous commit
Next Next commit
Temp: block date part for grain to date
courtneyholcomb committed Sep 13, 2023
commit 38761fec874fdd843f6283fe130ff64353e1ab89
1 change: 0 additions & 1 deletion metricflow/plan_conversion/dataflow_to_sql.py
Original file line number Diff line number Diff line change
@@ -1376,7 +1376,6 @@ def visit_join_to_time_spine_node(self, node: JoinToTimeSpineNode[SourceDataSetT
time_granularity=metric_time_dimension_spec.time_granularity, arg=time_spine_column_select_expr
)
if node.offset_to_grain:
# TODO: allow offset_to_grain w/ granularity & datepart? what's the expected behavior?
# Filter down to one row per granularity period
new_filter = SqlComparisonExpression(
left_expr=select_expr, comparison=SqlComparison.EQUALS, right_expr=time_spine_column_select_expr