Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedupe filter specs in join to time spine queries #1578

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

courtneyholcomb
Copy link
Contributor

@courtneyholcomb courtneyholcomb commented Dec 18, 2024

There was a duplicate spec being passed into one of the FilterElementsNodes, which caused duplicates to show up in the printed dataflow plan. This fixes that.

@cla-bot cla-bot bot added the cla:yes label Dec 18, 2024
@courtneyholcomb courtneyholcomb changed the base branch from main to court/custom-offset3 December 18, 2024 20:40
@courtneyholcomb courtneyholcomb force-pushed the court/custom-offset4 branch 2 times, most recently from f267e57 to 74c5cf7 Compare December 18, 2024 20:55
@dbt-labs dbt-labs deleted a comment from github-actions bot Dec 18, 2024
@courtneyholcomb courtneyholcomb changed the title Court/custom offset4 Dedupe filter specs in join to time spine queries Dec 18, 2024
@courtneyholcomb courtneyholcomb marked this pull request as ready for review December 18, 2024 20:56
@courtneyholcomb courtneyholcomb added the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Dec 18, 2024
@dbt-labs dbt-labs deleted a comment from github-actions bot Dec 18, 2024
@github-actions github-actions bot removed the Run Tests With Other SQL Engines Runs the test suite against the SQL engines in our target environment label Dec 18, 2024
Base automatically changed from court/custom-offset3 to main December 21, 2024 02:16
@courtneyholcomb courtneyholcomb enabled auto-merge (squash) December 21, 2024 02:29
@courtneyholcomb courtneyholcomb merged commit f6f63d7 into main Dec 21, 2024
11 checks passed
@courtneyholcomb courtneyholcomb deleted the court/custom-offset4 branch December 21, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants