Memoize results in SourceScanOptimizer for better CTE generation
#1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plypaul
force-pushed
the
plypaul--55--common-nodes-in-source-scan-optimizer
branch
from
3215b65 to
fe50fe2
Compare
WilliamDee
approved these changes
Dec 11, 2024
plypaul
deleted the
plypaul--55--common-nodes-in-source-scan-optimizer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generation of CTEs is determined by identical nodes in the dataflow plan. Previously, the
SourceScanOptimizerwould create new nodes whenever it was able to optimize a branch. In addition, it would create new nodes in some cases where it was not necessary.This PR updates
SourceScanOptimizerto memoize results so that identical nodes are used in cases where the dataflow branch is the same.This results in snapshot changes for tests where the optimizer previously prevented CTEs from being used - please view by commit.