Assorted formatting / logging updates #1518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
approved these changes
Nov 13, 2024
metricflow/dataset/sql_dataset.py
Outdated
| raise RuntimeError( | ||
| str( | ||
| LazyFormat( | ||
| f"{self} was created with a SQL node that is not a {SqlSelectStatementNode}", |
There was a problem hiding this comment.
Should we use the class name here instead of self? That way the logs will be more consistent/searchable and any changing attributes can go in the other args.
Also, wondering why SqlSelectStatementNode is in curly braces.
There was a problem hiding this comment.
I know this probably isn't an error you wrote - this doesn't need to block merge!
There are some cases where a description is not needed as it is added in other ways. e.g. when building a snapshot file, the description is added through snapshot helper methods.
This makes snapshot comparisons consistent between runs as the schema name will change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains an assortment of updates related to logging / formatting. Although not really related, since they were small, they were put into a single PR. Please view by commit.