Split traversal component from DataflowToSqlQueryPlanConverter
#1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plypaul
force-pushed
the
p--cte--12
branch
2 times, most recently
from
822d119 to
e264be5
Compare
courtneyholcomb
approved these changes
Nov 13, 2024
| @@ -1956,3 +1923,38 @@ def visit_window_reaggregation_node(self, node: WindowReaggregationNode) -> SqlD | |||
| group_bys=outer_query_select_columns, | |||
| ), | |||
| ) | |||
|
|
|||
| @staticmethod | |||
| def _make_time_range_comparison_expr( | |||
There was a problem hiding this comment.
thanks for encapsulating this in a better way 🙏
| ) | ||
|
|
||
|
|
||
| class DataflowNodeToSqlSubqueryVisitor(DataflowPlanNodeVisitor[SqlDataSet]): |
There was a problem hiding this comment.
I'm not sure about the name here - it feels like removing Subquery would be more accurate (i.e., DataflowNodeToSqlVisitor), since there isn't always a subquery involved. Technically, each node resolves to a full SQL query (and the parent node often resolves to a subquery).
There was a problem hiding this comment.
Maybe DataflowNodeToDefaultSqlVisitor? Issue with DataflowNodeToSqlVisitor is differentiating this one from the new one that uses CTEs. I'll have to put renames at the end due to stack conflicts though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits off the part that does the dataflow traversal in
DataflowToSqlQueryPlanConverterinto a separate class to reduce the class size. Later, these two parts can be put into different files.