Support expectations in snapshot files #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plypaul
force-pushed
the
p--misc-improvements--03
branch
from
9091615 to
33132e0
Compare
plypaul
force-pushed
the
p--misc-improvements--02
branch
from
63c86ce to
eb18b9b
Compare
plypaul
force-pushed
the
p--misc-improvements--03
branch
from
33132e0 to
dbb45c6
Compare
WilliamDee
approved these changes
Nov 8, 2024
plypaul
force-pushed
the
p--misc-improvements--02
branch
from
eb18b9b to
7e4e2eb
Compare
plypaul
force-pushed
the
p--misc-improvements--03
branch
from
dbb45c6 to
4b087c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make snapshot files easier to review, this PR adds an
expectation_descriptionfield to the headers. This way, reviewers can read the description to check that the snapshot contains the expected result. The field was namedexpectation_descriptioninstead ofexpectationto make it more clear that it's supposed to be human-readable text vs. a specific value in the snapshot.