Support for join_to_timespine metrics with custom grain in the group by
#1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
added
the
Run Tests With Other SQL Engines
courtneyholcomb
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
courtneyholcomb
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
courtneyholcomb
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
courtneyholcomb
had a problem deploying
to
DW_INTEGRATION_TESTS
GitHub Actions
Failure
github-actions
bot
removed
the
Run Tests With Other SQL Engines
courtneyholcomb
force-pushed
the
court/join-to-time-spine-custom
branch
2 times, most recently
from
c38c05d to
c777a36
Compare
courtneyholcomb
force-pushed
the
court/join-to-time-spine-custom
branch
from
c777a36 to
bc04559
Compare
courtneyholcomb
commented
Nov 5, 2024
| @@ -0,0 +1,17 @@ | |||
| booking__ds__martian_day bookings_join_to_time_spine | |||
There was a problem hiding this comment.
This is the expected result. All of the bookings source data maps to this martian_day.
courtneyholcomb
added
the
Run Tests With Other SQL Engines
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
WilliamDee
approved these changes
Nov 5, 2024
| for grain, time_spine_source in time_spine_sources.items() | ||
| if grain.to_int() <= smallest_required_standard_grain.to_int() | ||
| } | ||
| if not compatible_time_spines_for_standard_grains: |
There was a problem hiding this comment.
nit - non-blocking: I kinda like the readability of doing
if compatible_time_spines_for_standard_grains == {}:
# OR
if len(compatible_time_spines_for_standard_grains) == 0There was a problem hiding this comment.
Good call you have given me this feedback before, I'll try to remember in future!!
|
|
||
| # If the standard grains can't be satisfied by the same time spines as the custom grains, add the largest compatible one. | ||
| if not required_time_spines.intersection(set(compatible_time_spines_for_standard_grains.values())): | ||
| required_time_spines.add(time_spine_sources[max(compatible_time_spines_for_standard_grains.keys())]) |
There was a problem hiding this comment.
nit: you don't need .keys() since it already uses keys by default when you do any functions on a dict.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for using custom grains in the group by when querying
join_to_timespinemetrics.This includes only limited support for now. Later we will support:
JoinToTimeSpineNode