Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SourceScanOptimizer generating duplicated columns #1494

Merged
merged 9 commits into from
Nov 5, 2024
Merged

Fix SourceScanOptimizer generating duplicated columns #1494

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b0a54fe
Check when optimizing metric scans with similar aliases
serramatutu Oct 30, 2024
cac1d59
Add tests for derived metrics with shared aliases
serramatutu Oct 30, 2024
2f9bf6b
Add integration test for derived metrics with shared aliases
serramatutu Oct 30, 2024
ba207b9
Changelog entry
serramatutu Oct 30, 2024
86fbfbd
fixup! Changelog entry
serramatutu Nov 4, 2024
1b7d1bc
fixup! Check when optimizing metric scans with similar aliases
serramatutu Nov 4, 2024
8a7b603
fixup! Add tests for derived metrics with shared aliases
serramatutu Nov 4, 2024
57e0611
fixup! Add integration test for derived metrics with shared aliases
serramatutu Nov 4, 2024
3583f92
fixup! Add integration test for derived metrics with shared aliases
serramatutu Nov 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions tests_metricflow/integration/test_cases/itest_metrics.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,6 +551,21 @@ integration_test:
ds
) a
---
integration_test:
serramatutu marked this conversation as resolved.
Show resolved Hide resolved
name: shared_alias_derived_metric
description: Tests derived metrics which use the same alias for different things
model: SIMPLE_MODEL
metrics: ["derived_sharedalias_1a", "derived_sharedalias_2"]
group_bys: ["booking__is_instant"]
check_query: |
SELECT
is_instant AS booking__is_instant
, COUNT(*) - 10 AS derived_sharedalias_1a
, SUM(CASE WHEN is_instant THEN 1 ELSE 0 END) + 10 AS derived_sharedalias_2
FROM {{ source_schema }}.fct_bookings
GROUP BY
booking__is_instant
---
integration_test:
name: two_metrics_with_null_dimension_values
description: Tests querying two metrics with a dimension having a NULL values
Expand Down