Fix Bug with get_defined_time_granularity()
#1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WilliamDee
approved these changes
Oct 31, 2024
plypaul
force-pushed
the
p--short-term-perf--32
branch
from
700c4ec to
3589969
Compare
plypaul
force-pushed
the
p--short-term-perf--33
branch
from
9761de5 to
5312708
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug with
get_defined_time_granularity()as demonstrated in #1482.This also changes the signature of
DataflowPlanBuilder.__get_required_and_extraneous_linkable_specs()to pass in a more complete object (measure_spec_properties) so that a call toget_defined_time_granularity()is not required.