Improve performance of MetricTimeQueryValidationRule
#1481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
serramatutu
approved these changes
Oct 28, 2024
|
|
||
| valid_agg_time_dimension_specs = self._manifest_lookup.metric_lookup.get_valid_agg_time_dimensions_for_metric( | ||
| metric_reference | ||
| self._query_includes_metric_time = ( |
There was a problem hiding this comment.
lol this is so much better I didn't know you could do it like this. Next time I'll do it this way!
plypaul
force-pushed
the
p--short-term-perf--27
branch
from
5a5c7fa to
29b6a6c
Compare
plypaul
force-pushed
the
p--short-term-perf--28
branch
from
dde61a2 to
84d4827
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the performance of
MetricTimeQueryValidationRule. One of the reasons for the slow performance is that it currently makes calls toget_joinable_scd_specs_for_metric, which can be slow with large manifests. Instead, this runs checks based on the resolved group-by-items, which is a much smaller set.