-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support conversion metrics with custom grain #1475
Merged
Merged
Changes from 8 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
38df97a
Add helper
courtneyholcomb fb562aa
Cleanup
courtneyholcomb 2622e53
Update SourceNodeRecipe properties
courtneyholcomb 1a6d623
Add custom grain logic for conversion metrics
courtneyholcomb 876daf2
Add query rendering tests for conversion metrics with custom grain
courtneyholcomb 55dd1ba
Add SQL engine snapshots
courtneyholcomb 5c55bbc
Check query tests for conversion metrics with custom grain
courtneyholcomb 05aed81
Changelog
courtneyholcomb 64f6623
PR feedback - cleanup
courtneyholcomb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
kind: Features | ||
body: Support cumulative metrics queried with custom granularities. | ||
time: 2024-10-23T16:17:20.92419-07:00 | ||
custom: | ||
Author: courtneyholcomb | ||
Issue: "1475" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,20 +4,22 @@ | |
import itertools | ||
from abc import ABC, abstractmethod | ||
from dataclasses import dataclass | ||
from typing import Generic, List, Sequence, Tuple, TypeVar | ||
from typing import TYPE_CHECKING, Generic, List, Sequence, Tuple, TypeVar | ||
|
||
from dbt_semantic_interfaces.dataclass_serialization import SerializableDataclass | ||
from typing_extensions import override | ||
|
||
from metricflow_semantics.collection_helpers.merger import Mergeable | ||
from metricflow_semantics.specs.dimension_spec import DimensionSpec | ||
from metricflow_semantics.specs.entity_spec import EntitySpec | ||
from metricflow_semantics.specs.group_by_metric_spec import GroupByMetricSpec | ||
from metricflow_semantics.specs.instance_spec import InstanceSpec, InstanceSpecVisitor, LinkableInstanceSpec | ||
from metricflow_semantics.specs.measure_spec import MeasureSpec | ||
from metricflow_semantics.specs.metadata_spec import MetadataSpec | ||
from metricflow_semantics.specs.metric_spec import MetricSpec | ||
from metricflow_semantics.specs.time_dimension_spec import TimeDimensionSpec | ||
|
||
if TYPE_CHECKING: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Needed to resolve circular imports. |
||
from metricflow_semantics.specs.dimension_spec import DimensionSpec | ||
from metricflow_semantics.specs.entity_spec import EntitySpec | ||
from metricflow_semantics.specs.group_by_metric_spec import GroupByMetricSpec | ||
from metricflow_semantics.specs.measure_spec import MeasureSpec | ||
from metricflow_semantics.specs.metadata_spec import MetadataSpec | ||
from metricflow_semantics.specs.metric_spec import MetricSpec | ||
from metricflow_semantics.specs.time_dimension_spec import TimeDimensionSpec | ||
|
||
|
||
@dataclass(frozen=True) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Support conversion** metrics