-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional rendering & check query tests for custom grain #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
courtneyholcomb
force-pushed
the
court/test-custom
branch
from
October 18, 2024 21:47
dd0c0ad
to
e3bcc0c
Compare
courtneyholcomb
force-pushed
the
court/test-custom
branch
from
October 18, 2024 21:57
e3bcc0c
to
c095335
Compare
courtneyholcomb
changed the title
Rendering & check query tests for custom grain with multi-hop join
Additional rendering & check query tests for custom grain
Oct 18, 2024
Should not actually change behavior since we don't pass custom grains into this node
courtneyholcomb
force-pushed
the
court/test-custom
branch
from
October 18, 2024 22:54
c095335
to
a2d0d59
Compare
courtneyholcomb
requested review from
PaulVPham,
serramatutu,
DevonFulcher,
WilliamDee,
theyostalservice and
plypaul
and removed request for
PaulVPham
October 18, 2024 23:11
courtneyholcomb
added
the
Run Tests With Other SQL Engines
Runs the test suite against the SQL engines in our target environment
label
Oct 18, 2024
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
October 18, 2024 23:12 — with
GitHub Actions
Inactive
courtneyholcomb
had a problem deploying
to
DW_INTEGRATION_TESTS
October 18, 2024 23:12 — with
GitHub Actions
Failure
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
October 18, 2024 23:12 — with
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
October 18, 2024 23:12 — with
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
Runs the test suite against the SQL engines in our target environment
label
Oct 18, 2024
serramatutu
approved these changes
Oct 21, 2024
courtneyholcomb
added
the
Run Tests With Other SQL Engines
Runs the test suite against the SQL engines in our target environment
label
Oct 21, 2024
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
October 21, 2024 16:05 — with
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
October 21, 2024 16:05 — with
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
October 21, 2024 16:05 — with
GitHub Actions
Inactive
courtneyholcomb
temporarily deployed
to
DW_INTEGRATION_TESTS
October 21, 2024 16:05 — with
GitHub Actions
Inactive
github-actions
bot
removed
the
Run Tests With Other SQL Engines
Runs the test suite against the SQL engines in our target environment
label
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More tests & a little cleanup for custom grain.